linux-kernel - Re: [PATCH] smack: Add missing logging in bidirectional UDS connect check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B00EE8.4050606@schaufler-ca.com>
Date:	Fri, 09 Jan 2015 09:24:56 -0800
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Rafal Krypa <r.krypa@...sung.com>
CC:	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH] smack: Add missing logging in bidirectional UDS connect
 check

On 1/8/2015 9:52 AM, Rafal Krypa wrote:
> During UDS connection check, both sides are checked for write access to
> the other side. But only the first check is performed with audit support.
> The second one didn't produce any audit logs. This simple patch fixes that.
>
> Signed-off-by: Rafal Krypa <r.krypa@...sung.com>

Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-3.20

> ---
>  security/smack/smack_lsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 8716ade..a688f7b 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -3333,7 +3333,7 @@ static int smack_unix_stream_connect(struct sock *sock,
>  		if (rc == 0) {
>  			okp = osp->smk_out;
>  			skp = ssp->smk_in;
> -			rc = smk_access(okp, skp, MAY_WRITE, NULL);
> +			rc = smk_access(okp, skp, MAY_WRITE, &ad);
>  			rc = smk_bu_note("UDS connect", okp, skp,
>  						MAY_WRITE, rc);
>  		}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/