linux-kernel - Re: [PATCHv2] hwmon: (ina2xx) implement update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 9 Jan 2015 09:57:34 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Benoit Cousson <bcousson@...libre.com>,
	Patrick Titiano <ptitiano@...libre.com>,
	LM Sensors <lm-sensors@...sensors.org>
Subject: Re: [PATCHv2] hwmon: (ina2xx) implement update_interval attribute
 for ina226

On Fri, Jan 09, 2015 at 03:45:27PM +0100, Bartosz Golaszewski wrote:
> 2015-01-09 15:34 GMT+01:00 Guenter Roeck <linux@...ck-us.net>:
> > Unfortunately that only applies to INA226 and not INA219, where the time is
> > static
> > (at least so far).
> 
> Oops, I must have missed this one.
> 
> > I think we'll need to store the time in ina2xx_data and use the old
> > (constant)
> > value for ina219. Maybe add another variable into the configuration data
> > for the initial value and copy it from there during probe.
> 
> I tried to avoid adding another variable used by ina226 only, but
> well. It's kind of dull that these chips are supported by a single
> driver - their configuration register layout is completely different.
> 
On the other side the data registers are the same. There is always some
trade-off.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/