linux-kernel - Re: [PATCH] staging: lustre: Fix the warning messages about casting without _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANZNk80x4nTrdy+pv0n8_mXCuU-x2AYidCgAD5D7hipHV2gcbA@mail.gmail.com>
Date:	Fri, 9 Jan 2015 21:38:56 +0200
From:	Andrey Utkin <andrey.krieger.utkin@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	OSUOSL Drivers <devel@...verdev.osuosl.org>,
	bergwolf@...il.com, "Dilger, Andreas" <andreas.dilger@...el.com>,
	peterz@...radead.org, Shalin Mehta <shalinmehta85@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	majordomo@...r.kernel.org, gdonald@...il.com,
	tranmanphong@...il.com,
	"HPDD-discuss@...1.01.org" <HPDD-discuss@...1.01.org>,
	massa.nomura@...il.com
Subject: Re: [PATCH] staging: lustre: Fix the warning messages about casting
 without __user macro

2014-12-10 16:49 GMT+02:00 Greg KH <gregkh@...uxfoundation.org>:
> On Wed, Dec 10, 2014 at 07:09:59AM +0000, Al Viro wrote:
>> On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote:
>> > From: Shalin Mehta <shalinmehta85@...il.com>
>> >
>> > This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the assigned value should be user space pointer with __user macro. Where as here, the __user macro isn't used while casting.
>>
>> ... and pointers are not user space ones at all.  Which is to say, quit
>> messing with casts; it's not struct iovec.  Proper fix is to replace
>> it here (and in almost all places throughout drivers/staging/lustre) with
>> struct kvec.  And yes, such a patch had been sent.  Still not applied,
>> AFAICS...
>
> Yeah, it's in the merge window and I'll pick new staging patches back up
> when 3.19-rc1 is released.

Hi Greg,
Still no commits for
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c since Sun Nov
23 (staging: lustre: Coalesce string fragments) in linux-next. Maybe
the aforementioned commit got missed for merging?

-- 
Andrey Utkin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/