linux-kernel - Re: [PATCH] media; firewire: Remove no longer needed fix me comment in firedtv-ci.c for the function,fdtv_ca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <54B05E05.3090409@ladisch.de>
Date:	Sat, 10 Jan 2015 00:02:29 +0100
From:	Clemens Ladisch <clemens@...isch.de>
To:	Nicholas Krause <xerofoify@...il.com>, stefanr@...6.in-berlin.de
CC:	linux-media@...r.kernel.org, linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, mchehab@....samsung.com
Subject: Re: [PATCH] media; firewire: Remove no longer needed fix me comment
	in firedtv-ci.c for the function,fdtv_ca_ioctl

Nicholas Krause wrote:
> Removes the no longer fix me comment for if we need to set the tuner status with
> the line, avc_tuner_status(fdtv, &stat). This line is needed in order to set the
> tuner status after we have through the switch statement checking what fdtv function
> we need to call to use to try and setup the hardware successfully.

You have attempted to describe what fdtv_ca_ioctl() does, but your description
lacks any understanding of what avc_tuner_status() does, or how it might affect
the device, or whether it is necessary.

Please stop spamming us with useless patches.

> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---
>  drivers/media/firewire/firedtv-ci.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/firewire/firedtv-ci.c b/drivers/media/firewire/firedtv-ci.c
> index e63f582..9c038ba 100644
> --- a/drivers/media/firewire/firedtv-ci.c
> +++ b/drivers/media/firewire/firedtv-ci.c
> @@ -201,7 +201,6 @@ static int fdtv_ca_ioctl(struct file *file, unsigned int cmd, void *arg)
>  		err = -EOPNOTSUPP;
>  	}
>
> -	/* FIXME Is this necessary? */
>  	avc_tuner_status(fdtv, &stat);
>
>  	return err;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/