linux-kernel - Re: [PATCH char-misc-next 02/13] misc: mic: SCIF ring buffer infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150109230526.GB3614@kroah.com>
Date:	Fri, 9 Jan 2015 15:05:26 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudeep Dutt <sudeep.dutt@...el.com>
Cc:	Arnd Bergmann <arnd@...db.de>, Jonathan Corbet <corbet@....net>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	Dave Jiang <dave.jiang@...el.com>,
	Nikhil Rao <nikhil.rao@...el.com>,
	Ashutosh Dixit <ashutosh.dixit@...el.com>
Subject: Re: [PATCH char-misc-next 02/13] misc: mic: SCIF ring buffer
 infrastructure

On Wed, Dec 10, 2014 at 11:47:42AM -0800, Sudeep Dutt wrote:
> SCIF ring buffer is a single producer, single consumer byte stream ring
> buffer optimized for avoiding reads across the PCIe bus. The ring buffer is
> used to implement a receive queue for SCIF driver messaging between nodes and
> for byte stream messaging between SCIF endpoints. Each SCIF node has a
> receive queue for every other SCIF node, and each connected endpoint has a
> receive queue for messages from its peer. This pair of receive queues is
> referred to as a SCIF queue pair.

And the reason you aren't using the built-in kernel ring buffer code is
why?

You need to document that really well here, or use the in-kernel code
please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/