linux-kernel - Re: [PATCH v2 1/2] ipmi: Cleanup DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLWFG+tb3Fbia0c7YfUe0xksdi0mcAvqgJH8SHOL=bMm=g@mail.gmail.com>
Date:	Fri, 9 Jan 2015 15:57:29 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Corey Minyard <minyard@....org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	openipmi-developer <openipmi-developer@...ts.sourceforge.net>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 1/2] ipmi: Cleanup DEBUG_TIMING ifdef usage

On Fri, Jan 9, 2015 at 2:52 PM, Corey Minyard <minyard@....org> wrote:
> On 01/07/2015 04:24 PM, John Stultz wrote:
>> The driver uses #ifdef DEBUG_TIMING in order to conditionally print out
>> timestamped debug messages. Unfortunately it adds the ifdefs all over the
>> usage sites.
>>
>> This patch cleans it up by adding a debug_timestamp() function which
>> is compiled out if DEBUG_TIMING isn't present. This cleans up all
>> the ugly ifdefs in the function logic.
>
> Yes, this is much better.  I had looked at this recently and planned to
> do something
> with it.  Queued for 3.20, unless you need it sooner.

Nope, no rush. Just wanted to make sure it gets off my queue. :)

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/