linux-kernel - Re: [PATCH] hwmon: (ina2xx) implement update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54AF59F3.9080200@roeck-us.net>
Date:	Thu, 08 Jan 2015 20:32:51 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Benoit Cousson <bcousson@...libre.com>,
	Patrick Titiano <ptitiano@...libre.com>,
	LM Sensors <lm-sensors@...sensors.org>
Subject: Re: [PATCH] hwmon: (ina2xx) implement update_interval attribute for
 ina226

On 01/08/2015 10:14 AM, Bartosz Golaszewski wrote:
> 2015-01-08 18:05 GMT+01:00 Guenter Roeck <linux@...ck-us.net>:
>> What is the purpose of multiplying the calculated average by 2 ?
>
> The comment above says:
>
>> +     /*
>> +      * Add bus and shunt voltage conversion times and multiple them
>> +      * by the averaging rate. Return the result in milliseconds.
>> +      */
>
> Since both conversion times are the same and equal
> INA226_CONV_TIME_DEFAULT I just multiplied it by 2 - I thought it was
> clear enough. I'll fix that in the next iteration.
>

Sorry, still don't get it. I must be a bit slow today ;-)

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/