linux-kernel - Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B16D24.8090704@kernel.org>
Date:	Sat, 10 Jan 2015 18:19:16 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>,
	Karol Wrona <k.wrona@...sung.com>, linux-iio@...r.kernel.org,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>,
	linux-kernel@...r.kernel.org
CC:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Karol Wrona <wrona.vy@...il.com>
Subject: Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF

On 10/01/15 11:11, Lars-Peter Clausen wrote:
> On 01/08/2015 05:40 PM, Karol Wrona wrote:
>> iio kfifo can be used without trigger support so there is no need to build it.
>>
>> Signed-off-by: Karol Wrona <k.wrona@...sung.com>
> 
> Looks good, not sure why this was ever selected it in the first place.
> 
> Reviewed-by: Lars-Peter Clausen <lars@...afoo.de>
Applied to the togreg branch of iio.git initially pushed out as testing.
That's certainly been there a while. I got bored looking for the source
when we hit the move out of staging :)

oops for a long time ago - though prior to there being any examples
where a kfifo didn't meant there was a trigger as well.

J
> 
>> ---
>>   drivers/iio/Kconfig |    1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig
>> index 50f6599..dfda2c3 100644
>> --- a/drivers/iio/Kconfig
>> +++ b/drivers/iio/Kconfig
>> @@ -27,7 +27,6 @@ boolean "IIO callback buffer used for push in-kernel interfaces"
>>         usage.  That is, those where the data is pushed to the consumer.
>>
>>   config IIO_KFIFO_BUF
>> -    select IIO_TRIGGER
>>       tristate "Industrial I/O buffering based on kfifo"
>>       help
>>         A simple fifo based on kfifo.  Note that this currently provides
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/