[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150110224120.GJ12218@pd.tnic>
Date: Sat, 10 Jan 2015 23:41:20 +0100
From: Borislav Petkov <bp@...en8.de>
To: Denys Vlasenko <vda.linux@...glemail.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Denys Vlasenko <dvlasenk@...hat.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Oleg Nesterov <oleg@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>,
Andy Lutomirski <luto@...capital.net>,
Frederic Weisbecker <fweisbec@...il.com>,
X86 ML <x86@...nel.org>, Alexei Starovoitov <ast@...mgrid.com>,
Will Drewry <wad@...omium.org>,
Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH 3/4] x86: open-code register save/restore in
trace_hardirqs thunks
On Sat, Jan 10, 2015 at 11:35:58PM +0100, Denys Vlasenko wrote:
> I don't know either... it seems to be used after push_cfi
> *sometimes*, not always:
>
> .macro op_safe_regs op
> ENTRY(\op\()_safe_regs)
> CFI_STARTPROC
> pushl_cfi %ebx
> pushl_cfi %ebp
> pushl_cfi %esi
> pushl_cfi %edi
>
> but
>
> ENTRY(csum_partial)
> CFI_STARTPROC
> pushl_cfi %esi
> CFI_REL_OFFSET esi, 0
> pushl_cfi %ebx
> CFI_REL_OFFSET ebx, 0
>
> We need an expert to enlighten us.
I think Andy had it:
https://lkml.kernel.org/r/CALCETrUuJ8T%2BLp23uYezHvxAtF-L_20dOaD4aDxciE7xZqDK3w@mail.gmail.com
So we better hide that crap in the macro at least, like the rest of the
CFI gunk.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists