linux-kernel - Re: [PATCH] staging, addi_apci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150110015006.GA20327@kroah.com>
Date:	Fri, 9 Jan 2015 17:50:06 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging, addi_apci_1500: fix IRQ spew

On Wed, Dec 10, 2014 at 02:42:01PM +0000, Alan Cox wrote:
> The driver very carefully checks if the card is the IRQ source, and if it
> isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it
> can be used on a shared interrupt line.
> 
> Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
>  .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> index 0ea081e..b7b9857 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> @@ -2175,10 +2175,6 @@ static void apci1500_interrupt(int irq, void *d)
>  			devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
>  		/* Authorizes the main interrupt on the board */
>  		outb(0xD0, devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
> -	} else {
> -		dev_warn(dev->class_dev,
> -			"Interrupt from unknown source\n");
> -
>  	}
>  }
>  

No longer applies to my tree due to other changes in this driver :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/