linux-kernel - Re: [PATCH 00/25] line6usb cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAEUsAPaDdXO_0z0sWp_M_sYV69N44+Ea7eqm1VvPA2mONUerag@mail.gmail.com>
Date:	Sun, 11 Jan 2015 15:04:55 -0600
From:	Chris Rorvick <chris@...vick.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	Davide Berardi <berardi.dav@...il.com>,
	devel@...verdev.osuosl.org,
	Fabian Mewes <architekt@...ing4coffee.org>,
	Gulsah Kose <gulsah.1004@...il.com>,
	Himangi Saraogi <himangi774@...il.com>,
	Jerry Snitselaar <dev@...tselaar.org>,
	L. Alberto Giménez <agimenez@...valve.es>,
	linux-kernel@...r.kernel.org, Mikhail Boiko <mm.boiko@...dex.ru>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Stefan Hajnoczi <stefanha@...il.com>
Subject: Re: [PATCH 00/25] line6usb cleanup

> At Fri,  9 Jan 2015 23:35:46 -0600,
> Chris Rorvick wrote:
>>
>> I have a TonePort UX2 that I've used for testing, meaning that some of
>> this is really only compile-tested.
>
> If anyone is responsible for testing with real hardware, I'll happily
> review.

To be clear, the TonePort UX2 is real hardware.  But this driver
basically supports four classes of Line 6 devices and I'm only covering
one of them.

So this series is a first step in trying to address this.  Having this
as a single driver probably made sense when it was a separate project,
but now that it is in-tree it seems like the POD, PODHD, TonePort, and
Variax pieces should each be separate drivers that each depend on a core
Line 6 driver.  I think the cleanup in this series will make that
easier.  None of this is my area of expertise, though, so advice and
feedback is very welcome.

> are there any active developers for this driver?

I intended to do further work.  I know there is quite a bit of mundane
checkpatch cleanup that would need to get done before this could get
promoted, and I believe I read that it's using sysfs for stuff that
would normally be done via an ALSA interface, and the sysfs interface
has not been documented nor has it been justified.  All stuff I thought
I might look into.

But I'm just doing this for fun so I can't promise anything.  :-)

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/