linux-kernel - Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVpEGQ0vkPKHDwF=1LHjLJSvyBi-yo_2rBoqQ2rF_S3+A@mail.gmail.com>
Date:	Sun, 11 Jan 2015 11:42:57 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	linux-m68k <linux-m68k@...ts.linux-m68k.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function

On Mon, Jan 5, 2015 at 12:39 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Thu, Jan 1, 2015 at 5:49 PM, Rickard Strandqvist
> <rickard_strandqvist@...ctrumdigital.se> wrote:
>> Remove the function mvme147_init_console_port() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
>> ---
>>  arch/m68k/mvme147/config.c |    5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
>> index 1bb3ce6..5da5e6e 100644
>> --- a/arch/m68k/mvme147/config.c
>> +++ b/arch/m68k/mvme147/config.c
>> @@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
>>         }
>>         local_irq_restore(flags);
>>  }
>> -
>> -void mvme147_init_console_port (struct console *co, int cflag)
>> -{
>> -       co->write    = m147_scc_write;
>> -}
>
> And after that m147_scc_write() becomes unused, and scc_write(), and
> scc_delay()... I will remove these, too.

Thanks, applied and queued for 3.20.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/