linux-kernel - Re: [PATCH] mm: fix corner case in anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150112095046.GB4877@dhcp22.suse.cz>
Date:	Mon, 12 Jan 2015 10:50:46 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Konstantin Khlebnikov <koct9i@...il.com>
Cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Rik van Riel <riel@...hat.com>,
	"Elifaz, Dana" <Dana.Elifaz@....com>,
	"Bridgman, John" <John.Bridgman@....com>,
	Daniel Forrest <dan.forrest@...c.wisc.edu>,
	Chris Clayton <chris2553@...glemail.com>,
	Oded Gabbay <oded.gabbay@....com>
Subject: Re: [PATCH] mm: fix corner case in anon_vma endless growing
 prevention

On Sun 11-01-15 16:54:06, Konstantin Khlebnikov wrote:
> Fix for BUG_ON(anon_vma->degree) splashes in unlink_anon_vmas()
> ("kernel BUG at mm/rmap.c:399!").
> 
> Anon_vma_clone() is usually called for a copy of source vma in destination
> argument. If source vma has anon_vma it should be already in dst->anon_vma.
> NULL in dst->anon_vma is used as a sign that it's called from anon_vma_fork().
> In this case anon_vma_clone() finds anon_vma for reusing.
> 
> Vma_adjust() calls it differently and this breaks anon_vma reusing logic:
> anon_vma_clone() links vma to old anon_vma and updates degree counters but
> vma_adjust() overrides vma->anon_vma right after that. As a result final
> unlink_anon_vmas() decrements degree for wrong anon_vma.
> 
> This patch assigns ->anon_vma before calling anon_vma_clone().
> 
> Signed-off-by: Konstantin Khlebnikov <koct9i@...il.com>
> Fixes: 7a3ef208e662 ("mm: prevent endless growth of anon_vma hierarchy")
> Tested-by: Chris Clayton <chris2553@...glemail.com>
> Tested-by: Oded Gabbay <oded.gabbay@....com>
> Cc: Daniel Forrest <dan.forrest@...c.wisc.edu>
> Cc: Michal Hocko <mhocko@...e.cz>
> Cc: Rik van Riel <riel@...hat.com>

Reviewed-by: Michal Hocko <mhocko@...e.cz>

> ---
>  mm/mmap.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 7b36aa7..12616c5 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -778,10 +778,12 @@ again:			remove_next = 1 + (end > next->vm_end);
>  		if (exporter && exporter->anon_vma && !importer->anon_vma) {
>  			int error;
>  
> +			importer->anon_vma = exporter->anon_vma;
>  			error = anon_vma_clone(importer, exporter);
> -			if (error)
> +			if (error) {
> +				importer->anon_vma = NULL;
>  				return error;
> -			importer->anon_vma = exporter->anon_vma;
> +			}
>  		}
>  	}
>  
> 

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/