linux-kernel - Re: [PATCH 1/1 linux-next] udf: destroy sbi mutex in put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150112095834.GB4468@quack.suse.cz>
Date:	Mon, 12 Jan 2015 10:58:34 +0100
From:	Jan Kara <jack@...e.cz>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH 1/1 linux-next] udf: destroy sbi mutex in put_super

On Sat 10-01-15 19:13:32, Fabian Frederick wrote:
> Call mutex_destroy() on superblock mutex in udf_put_super()
> otherwise mutex debugging code isn't able to detect that
> mutex is used after being freed.
> (thanks to Jan Kara for complete definition).
  Applied, thanks.

							Honza

> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  fs/udf/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 3ccb2f1..3d35a75 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -2300,6 +2300,7 @@ static void udf_put_super(struct super_block *sb)
>  		udf_close_lvid(sb);
>  	brelse(sbi->s_lvid_bh);
>  	udf_sb_free_partitions(sb);
> +	mutex_destroy(&sbi->s_alloc_mutex);
>  	kfree(sb->s_fs_info);
>  	sb->s_fs_info = NULL;
>  }
> -- 
> 2.1.0
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/