linux-kernel - Re: [PATCH] x86: kvm: vmx: Remove some unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B39DFD.60004@redhat.com>
Date:	Mon, 12 Jan 2015 11:12:13 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Gleb Natapov <gleb@...nel.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: kvm: vmx: Remove some unused functions

On 11/01/2015 19:02, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> cpu_has_vmx_eptp_writeback() cpu_has_vmx_eptp_uncacheable()
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  arch/x86/kvm/vmx.c |   10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 3e556c6..e273f15 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -951,16 +951,6 @@ static inline bool cpu_has_vmx_ept_execute_only(void)
>  	return vmx_capability.ept & VMX_EPT_EXECUTE_ONLY_BIT;
>  }
>  
> -static inline bool cpu_has_vmx_eptp_uncacheable(void)
> -{
> -	return vmx_capability.ept & VMX_EPTP_UC_BIT;
> -}
> -
> -static inline bool cpu_has_vmx_eptp_writeback(void)
> -{
> -	return vmx_capability.ept & VMX_EPTP_WB_BIT;
> -}
> -
>  static inline bool cpu_has_vmx_ept_2m_page(void)
>  {
>  	return vmx_capability.ept & VMX_EPT_2MB_PAGE_BIT;
> 

Looks good, thanks.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/