linux-kernel - Re: [PATCH v8 12/14] x86: perf: intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iogcnp5m.fsf@ashishki-desk.ger.corp.intel.com>
Date:	Mon, 12 Jan 2015 14:45:25 +0200
From:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Robert Richter <rric@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>, kan.liang@...el.com,
	adrian.hunter@...el.com, markus.t.metzger@...el.com,
	mathieu.poirier@...aro.org, acme@...radead.org
Subject: Re: [PATCH v8 12/14] x86: perf: intel_pt: Intel PT PMU driver

Peter Zijlstra <peterz@...radead.org> writes:

> On Fri, Nov 14, 2014 at 03:43:45PM +0200, Alexander Shishkin wrote:
>> +static void pt_handle_status(struct pt *pt)
>> +{
>> +	struct pt_buffer *buf = perf_get_aux(&pt->handle);
>> +	int advance = 0;
>> +	u64 status;
>> +
>> +	rdmsrl(MSR_IA32_RTIT_STATUS, status);
>> +
>> +	if (status & RTIT_STATUS_ERROR) {
>> +		pr_err_ratelimited("ToPA ERROR encountered, trying to recover\n");
>> +		pt_topa_dump(buf);
>> +		status &= ~RTIT_STATUS_ERROR;
>> +	}
>> +
>> +	if (status & RTIT_STATUS_STOPPED) {
>> +		status &= ~RTIT_STATUS_STOPPED;
>> +
>> +		/*
>> +		 * On systems that only do single-entry ToPA, hitting STOP
>> +		 * means we are already losing data; need to let the decoder
>> +		 * know.
>> +		 */
>> +		if (!pt_cap_get(PT_CAP_topa_multiple_entries) ||
>> +		    buf->output_off == sizes(TOPA_ENTRY(buf->cur, buf->cur_idx)->size)) {
>> +			local_inc(&buf->lost);
>> +			advance++;
>> +		}
>> +	}
>> +
>> +	/*
>> +	 * Also on single-entry ToPA implementations, interrupt will come
>> +	 * before the output reaches its output region's boundary.
>> +	 */
>
> My understanding was that, while yes it will attempt to generate the
> interrupt early, there is absolutely no guarantee it will in fact arrive
> in time or even it if does, guarantee that there is buffer left by the
> time you're ready to read it.

That's correct. If the PMI didn't arrive on time and the buffer got
filled up, the STOPPED bit will be set in the STATUS register, which is
what we're handling above.

>> +	if (!pt_cap_get(PT_CAP_topa_multiple_entries) && !buf->snapshot &&
>> +	    pt_buffer_region_size(buf) - buf->output_off <= TOPA_PMI_MARGIN) {
>
> Now this check appears to indeed cater for this scenario where the
> buffer is overran, right?

The check above is for the case when the PMI did make it before the end
of the physical buffer was reached.

>
>> +		void *head = pt_buffer_region(buf);
>> +
>> +		/* everything within this margin needs to be zeroed out */
>> +		memset(head + buf->output_off, 0,
>> +		       pt_buffer_region_size(buf) -
>> +		       buf->output_off);
>> +		advance++;
>> +	}
>> +
>> +	if (advance)
>> +		pt_buffer_advance(buf);
>> +
>> +	wrmsrl(MSR_IA32_RTIT_STATUS, status);
>> +}

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/