linux-kernel - Re: [PATCH v5 3/5] KVM: arm/arm64: implement kvm_arch_is_virtual_intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B3CEBF.3020108@linaro.org>
Date:	Mon, 12 Jan 2015 14:40:15 +0100
From:	Eric Auger <eric.auger@...aro.org>
To:	Christoffer Dall <christoffer.dall@...aro.org>
CC:	eric.auger@...com, marc.zyngier@....com,
	linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
	kvm@...r.kernel.org, alex.williamson@...hat.com, agraf@...e.de,
	joel.schopp@....com, gleb@...nel.org, pbonzini@...hat.com,
	borntraeger@...ibm.com, cornelia.huck@...ibm.com,
	linux-kernel@...r.kernel.org, patches@...aro.org,
	a.motakis@...tualopensystems.com
Subject: Re: [PATCH v5 3/5] KVM: arm/arm64: implement kvm_arch_is_virtual_intc_initialized

On 01/11/2015 10:12 PM, Christoffer Dall wrote:
> On Wed, Dec 03, 2014 at 05:07:10PM +0100, Eric Auger wrote:
>> on arm/arm64 the VGIC is dynamically instantiated and it is useful
>> to expose its state, especially for irqfd setup.
>>
>> This patch defines __KVM_HAVE_ARCH_VIRTUAL_INTC_INITIALIZED
>> and implements kvm_arch_is_virtual_intc_initialized
>>
>> Signed-off-by: Eric Auger <eric.auger@...aro.org>
>> ---
>>  arch/arm/include/asm/kvm_host.h   | 6 ++++++
>>  arch/arm/kvm/arm.c                | 5 +++++
>>  arch/arm64/include/asm/kvm_host.h | 5 +++++
>>  3 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
>> index 53036e2..fe2c89b 100644
>> --- a/arch/arm/include/asm/kvm_host.h
>> +++ b/arch/arm/include/asm/kvm_host.h
>> @@ -27,6 +27,8 @@
>>  #include <asm/fpstate.h>
>>  #include <kvm/arm_arch_timer.h>
>>  
>> +#define __KVM_HAVE_ARCH_VIRTUAL_INTC_INITIALIZED
>> +
>>  #if defined(CONFIG_KVM_ARM_MAX_VCPUS)
>>  #define KVM_MAX_VCPUS CONFIG_KVM_ARM_MAX_VCPUS
>>  #else
>> @@ -242,4 +244,8 @@ static inline void kvm_arch_sync_events(struct kvm *kvm) {}
>>  static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {}
>>  static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {}
>>  
>> +/* returns true if the vgic dynamic initialization is done*/
>> +bool kvm_arch_is_virtual_intc_initialized(struct kvm *kvm);
> 
> I feel like this should go in include/linux/kvm_host.h where there's
> already a description of the function API.
agreed

Eric
> 
>> +
>> +
>>  #endif /* __ARM_KVM_HOST_H__ */
>> diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
>> index 9e193c8..5309e4b 100644
>> --- a/arch/arm/kvm/arm.c
>> +++ b/arch/arm/kvm/arm.c
>> @@ -439,6 +439,11 @@ static int kvm_vcpu_first_run_init(struct kvm_vcpu *vcpu)
>>  	return 0;
>>  }
>>  
>> +bool kvm_arch_is_virtual_intc_initialized(struct kvm *kvm)
>> +{
>> +	return vgic_initialized(kvm);
>> +}
>> +
>>  static void vcpu_pause(struct kvm_vcpu *vcpu)
>>  {
>>  	wait_queue_head_t *wq = kvm_arch_vcpu_wq(vcpu);
>> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
>> index 2012c4b..5badd30 100644
>> --- a/arch/arm64/include/asm/kvm_host.h
>> +++ b/arch/arm64/include/asm/kvm_host.h
>> @@ -28,6 +28,8 @@
>>  #include <asm/kvm_asm.h>
>>  #include <asm/kvm_mmio.h>
>>  
>> +#define __KVM_HAVE_ARCH_VIRTUAL_INTC_INITIALIZED
>> +
>>  #if defined(CONFIG_KVM_ARM_MAX_VCPUS)
>>  #define KVM_MAX_VCPUS CONFIG_KVM_ARM_MAX_VCPUS
>>  #else
>> @@ -254,4 +256,7 @@ static inline void kvm_arch_sync_events(struct kvm *kvm) {}
>>  static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {}
>>  static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {}
>>  
>> +/* returns true if the vgic dynamic initialization is done*/
>> +bool kvm_arch_is_virtual_intc_initialized(struct kvm *kvm);
>> +
>>  #endif /* __ARM64_KVM_HOST_H__ */
>> -- 
>> 1.9.1
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/