linux-kernel - Re: [PATCH v2 2/3] media: au0828 change to not zero out fmt.pix.priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B3D319.2090506@xs4all.nl>
Date:	Mon, 12 Jan 2015 14:58:49 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Shuah Khan <shuahkh@....samsung.com>, m.chehab@...sung.com,
	hans.verkuil@...co.com, dheitmueller@...nellabs.com,
	prabhakar.csengg@...il.com, sakari.ailus@...ux.intel.com,
	laurent.pinchart@...asonboard.com, ttmesterr@...il.com
CC:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] media: au0828 change to not zero out fmt.pix.priv

My first code review of the new year, so let's start with a simple one to avoid
taxing my brain cells (that are still in vacation mode) too much...

On 12/18/2014 05:20 PM, Shuah Khan wrote:
> There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap()
> vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it.
> 
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>

Acked-by: Hans Verkuil <hans.verkuil@...co.com>

Happy New Year!

	Hans

> ---
>  drivers/media/usb/au0828/au0828-video.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c
> index 3011ca8..ef49b2e 100644
> --- a/drivers/media/usb/au0828/au0828-video.c
> +++ b/drivers/media/usb/au0828/au0828-video.c
> @@ -1104,7 +1104,6 @@ static int au0828_set_format(struct au0828_dev *dev, unsigned int cmd,
>  	format->fmt.pix.sizeimage = width * height * 2;
>  	format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M;
>  	format->fmt.pix.field = V4L2_FIELD_INTERLACED;
> -	format->fmt.pix.priv = 0;
>  
>  	if (cmd == VIDIOC_TRY_FMT)
>  		return 0;
> @@ -1189,7 +1188,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv,
>  	f->fmt.pix.sizeimage = dev->frame_size;
>  	f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; /* NTSC/PAL */
>  	f->fmt.pix.field = V4L2_FIELD_INTERLACED;
> -	f->fmt.pix.priv = 0;
>  	return 0;
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/