linux-kernel - Re: [PATCH] staging: skein: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150112144047.GY24989@titan.lakedaemon.net>
Date:	Mon, 12 Jan 2015 09:40:47 -0500
From:	Jason Cooper <jason@...edaemon.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Arno Tiemersma <arno.tiemersma@...il.com>,
	devel@...verdev.osuosl.org, eric.rost@...abylon.net,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	jake@....net, antonysaraev@...il.com
Subject: Re: [PATCH] staging: skein: Fix checkpatch warnings

On Mon, Jan 12, 2015 at 05:33:47PM +0300, Dan Carpenter wrote:
> On Mon, Jan 12, 2015 at 09:14:18AM -0500, Jason Cooper wrote:
> > Arno,
> > 
> > On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote:
> > > Remove do {} while (0) loops around single statements in
> > > skein/skein_block.c
> > > 
> > > Signed-off-by: Arno Tiemersma <arno.tiemersma@...il.com>
> > > ---
> > >  drivers/staging/skein/skein_block.c | 16 ++++------------
> > >  1 file changed, 4 insertions(+), 12 deletions(-)
> > 
> > Is this a V2?  Several people have been submitting patches for this
> > checkpatch issue.  Please check the staging ML and deconflict with other
> > submitters.
> 
> Why would it be a v2?

I had asked one person to do a little extra work validating that
removing the do{}while's hadn't changed the resulting object code.
Unfortunately, I forgot who that was :(  Only because there have been so
many people submitting the exact same thing, though...

> It's really normal to get a wave of people sending the exact same patch.
> There was one time where 7 people deleted the same whitespace in
> panel.c.

I suspect this is a combination of a) checkpatch.pl getting a more
enhanced handling of do{}while's in macros, and b) more folks doing the
Eudiptula (sp?) challenge.

> Don't worry too much about conflicts.  It either applies when Greg reads
> it or it doesn't and he kicks off an email.  Not a big deal.

Agreed from a patch management side.  I was attempting to encourage the
new submitters to starting integrating the mailinglist into their
workflow.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/