linux-kernel - Re: [PATCH 4/5] sound: dmasound_atari: Remove obsolete IRQ_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk30sj84b.wl-tiwai@suse.de>
Date:	Mon, 12 Jan 2015 17:07:00 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 4/5] sound: dmasound_atari: Remove obsolete IRQ_TYPE_SLOW

At Mon, 12 Jan 2015 09:40:20 +0100,
Geert Uytterhoeven wrote:
> 
> IRQ_TYPE_SLOW is no longer used by the Atari platform interrupt code
> since commit 734085651c9b80aa ("[PATCH] m68k: convert atari irq code")
> in v2.6.18-rc1, so drop it.
> 
> Note that its value has been reused for a different purpose
> (IRQ_TYPE_NONE) since commit 6a6de9ef5850d063 ("[PATCH] genirq: core")
> in v2.6.18-rc1.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: alsa-devel@...a-project.org

I guess it's easier to take all patches into your tree, so take my
ack:
  Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi

> ---
>  sound/oss/dmasound/dmasound_atari.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c
> index 13c214466d3b9f0e..1c56bf58eff906e0 100644
> --- a/sound/oss/dmasound/dmasound_atari.c
> +++ b/sound/oss/dmasound/dmasound_atari.c
> @@ -851,7 +851,7 @@ static int __init AtaIrqInit(void)
>  	st_mfp.tim_dt_a = 1;	/* Cause interrupt after first event. */
>  	st_mfp.tim_ct_a = 8;	/* Turn on event counting. */
>  	/* Register interrupt handler. */
> -	if (request_irq(IRQ_MFP_TIMA, AtaInterrupt, IRQ_TYPE_SLOW, "DMA sound",
> +	if (request_irq(IRQ_MFP_TIMA, AtaInterrupt, 0, "DMA sound",
>  			AtaInterrupt))
>  		return 0;
>  	st_mfp.int_en_a |= 0x20;	/* Turn interrupt on. */
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/