[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1421083700-25258-1-git-send-email-martink@posteo.de>
Date: Mon, 12 Jan 2015 18:28:17 +0100
From: Martin Kepplinger <martink@...teo.de>
To: mingo@...nel.org
Cc: peterz@...radead.org, paulmck@...ux.vnet.ibm.com, tytso@....edu,
maxime.coquelin@...com, linux@...ck-us.net,
linux-kernel@...r.kernel.org, Martin Kepplinger <martink@...teo.de>
Subject: [RFC] input: gtco: use bitops' sign_extend8
Example change, using new sign_extend functions.
---
drivers/input/tablet/gtco.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet/gtco.c
index 8580456..25b3834 100644
--- a/drivers/input/tablet/gtco.c
+++ b/drivers/input/tablet/gtco.c
@@ -59,7 +59,7 @@ Scott Hill shill@...ocalcomp.com
#include <asm/uaccess.h>
#include <asm/unaligned.h>
#include <asm/byteorder.h>
-
+#include <linux/bitops.h>
#include <linux/usb/input.h>
@@ -666,13 +666,8 @@ static void gtco_urb_callback(struct urb *urbinfo)
case 4:
/* Tilt */
- /* Sign extend these 7 bit numbers. */
- if (device->buffer[6] & 0x40)
- device->buffer[6] |= 0x80;
-
- if (device->buffer[7] & 0x40)
- device->buffer[7] |= 0x80;
-
+ device->buffer[6] = sign_extend8(device->buffer[6], 6);
+ device->buffer[7] = sign_extend8(device->buffer[6], 6);
valsigned = (device->buffer[6]);
input_report_abs(inputdev, ABS_TILT_X, (s32)valsigned);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists