linux-kernel - Re: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150113064840.GA17714@sudip-PC>
Date:	Tue, 13 Jan 2015 12:18:40 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Emrys Bayliss <emrys@...adise.net.nz>, forest@...ttletooquiet.net,
	tvboxspy@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or
 return

On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
> On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > > 
> > > any reason why this return was removed ?
> > 
> > Because it's not needed.
> 
> yes, it is not needed. but the way Emrys Bayliss has changed the code, then we will get a compiler warning about no return statement.
i should have mentioned in my last mail that compiler will give waring if we compile with W=3 

sudip

> the code becomes :
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/