linux-kernel - Re: [PATCH] mm: fix corner case in anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALYGNiNtMgiHD9qQnczeWZy25wQ10LfQhoEGkW8KTbVfp9mBoA@mail.gmail.com>
Date:	Tue, 13 Jan 2015 10:53:42 +0400
From:	Konstantin Khlebnikov <koct9i@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Rik van Riel <riel@...hat.com>,
	"Elifaz, Dana" <Dana.Elifaz@....com>,
	"Bridgman, John" <John.Bridgman@....com>,
	Daniel Forrest <dan.forrest@...c.wisc.edu>,
	Chris Clayton <chris2553@...glemail.com>,
	Oded Gabbay <oded.gabbay@....com>,
	Michal Hocko <mhocko@...e.cz>, Greg KH <gregkh@...e.de>
Subject: Re: [PATCH] mm: fix corner case in anon_vma endless growing prevention

On Mon, Jan 12, 2015 at 11:21 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Sun, 11 Jan 2015 16:54:06 +0300 Konstantin Khlebnikov <koct9i@...il.com> wrote:
>
>> Fix for BUG_ON(anon_vma->degree) splashes in unlink_anon_vmas()
>> ("kernel BUG at mm/rmap.c:399!").
>>
>> Anon_vma_clone() is usually called for a copy of source vma in destination
>> argument. If source vma has anon_vma it should be already in dst->anon_vma.
>> NULL in dst->anon_vma is used as a sign that it's called from anon_vma_fork().
>> In this case anon_vma_clone() finds anon_vma for reusing.
>>
>> Vma_adjust() calls it differently and this breaks anon_vma reusing logic:
>> anon_vma_clone() links vma to old anon_vma and updates degree counters but
>> vma_adjust() overrides vma->anon_vma right after that. As a result final
>> unlink_anon_vmas() decrements degree for wrong anon_vma.
>>
>> This patch assigns ->anon_vma before calling anon_vma_clone().
>>
>> Signed-off-by: Konstantin Khlebnikov <koct9i@...il.com>
>> Fixes: 7a3ef208e662 ("mm: prevent endless growth of anon_vma hierarchy")
>
> I've asked Greg not to take 7a3ef208e662 into -stable because of this
> problem.  So if you still think we should fix this in -stable, could
> you please prepare an updated patch and send it to Greg?

Will do. But let's wait for some just to be sure that is the last bug here.

>
>> Tested-by: Chris Clayton <chris2553@...glemail.com>
>> Tested-by: Oded Gabbay <oded.gabbay@....com>
>> Cc: Daniel Forrest <dan.forrest@...c.wisc.edu>
>> Cc: Michal Hocko <mhocko@...e.cz>
>> Cc: Rik van Riel <riel@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/