linux-kernel - Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54B4DDC9.2000902@metafoo.de>
Date:	Tue, 13 Jan 2015 09:56:41 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Bo Shen <voice.shen@...el.com>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
CC:	alsa-devel@...a-project.org, Mark Brown <broonie@...nel.org>,
	linux-sound@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning

On 01/13/2015 06:36 AM, Bo Shen wrote:
> Hi Lars-Perter Clausen,
>
> On 01/12/2015 05:30 PM, Lars-Peter Clausen wrote:
>> On 01/12/2015 04:32 AM, Bo Shen wrote:
>> [...]
>>>>> diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c
>>>>> index 4d2d2b1..38582d7 100644
>>>>> --- a/sound/soc/codecs/wm8904.c
>>>>> +++ b/sound/soc/codecs/wm8904.c
>>>>> @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route
>>>>> adc_intercon[] = {
>>>>>       { "Right Capture PGA", NULL, "Right Capture Mux" },
>>>>>       { "Right Capture PGA", NULL, "Right Capture Inverting Mux" },
>>>>>
>>>>> -    { "AIFOUTL", "Left",  "ADCL" },
>>>>> -    { "AIFOUTL", "Right", "ADCR" },
>>>>> -    { "AIFOUTR", "Left",  "ADCL" },
>>>>> -    { "AIFOUTR", "Right", "ADCR" },
>>>>> +    { "AIFOUTL", NULL, "ADCL" },
>>>>> +    { "AIFOUTL", NULL, "ADCR" },
>>>>> +    { "AIFOUTR", NULL, "ADCL" },
>>>>> +    { "AIFOUTR", NULL, "ADCR" },
>>>>
>>>> Is this the right fix here? I am not super familiar with the
>>>> driver but it appears to contain an "AIFOUTL Mux" control which
>>>> is not connected to anything. Looks like maybe this is a mistake
>>>> the mux is indeded to be included in the path? Feels like we
>>>> should either remove the control as well or hook it into the
>>>> path.
>>>
>>> Thank for your information.
>>> I think here it should correct the path name as
>>> --->8---
>>> { "AIFOUTL Mux", "Left",  "ADCL" },
>>> { "AIFOUTL Mux", "Right", "ADCR" },
>>> { "AIFOUTR Mux", "Left",  "ADCL" },
>>> { "AIFOUTR Mux", "Right", "ADCR" },
>>> ---8<---
>>>
>>> Thanks again. I will send out the new version.
>>
>> Your probably also need to connect the mux to the output pins.
>
> Thanks for you information, after check the datasheet, I still don't know
> which the mux should connect to which output pins.

AIFOUTL Mux to AIFOUTL
AIFOUTR Mux to AIFOUTR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/