linux-kernel - Re: [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target() under CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 10:45:17 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	linux-mm@...ck.org
Subject: Re: [PATCH 1/1 linux-next] mm,compaction: move suitable_migration_target()
 under CONFIG_COMPACTION

On 01/09/2015 10:30 PM, Fabian Frederick wrote:
> 
> 
>> On 06 January 2015 at 18:21 Vlastimil Babka <vbabka@...e.cz> wrote:
>>
>>
>> On 01/03/2015 05:04 PM, Fabian Frederick wrote:
>> > suitable_migration_target() is only used by isolate_freepages()
>> > Define it under CONFIG_COMPACTION || CONFIG_CMA is not needed.
>> >
>> > Fix the following warning:
>> > mm/compaction.c:311:13: warning: 'suitable_migration_target' defined
>> > but not used [-Wunused-function]
>> >
>> > Signed-off-by: Fabian Frederick <fabf@...net.be>
>>
>> I agree, I would just move it to the section where isolation_suitable() and
>> related others are, maybe at the end of this section below
>> update_pageblock_skip()?
> 
> Yes of course, that would solve the warning as well.

So, send a v2? :)
Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/