linux-kernel - Re: [PATCH] driver core: property: support for generic property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150113103721.GB1856@kuha.fi.intel.com>
Date:	Tue, 13 Jan 2015 12:37:21 +0200
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH] driver core: property: support for generic property

On Tue, Jan 13, 2015 at 10:35:09AM +0100, Rafael J. Wysocki wrote:
> > @@ -51,13 +175,6 @@ EXPORT_SYMBOL_GPL(fwnode_property_present);
> >  	(val) ? of_property_read_##type##_array((node), (propname), (val), (nval)) \
> >  	      : of_property_count_elems_of_size((node), (propname), sizeof(type))
> >  
> > -#define DEV_PROP_READ_ARRAY(_dev_, _propname_, _type_, _proptype_, _val_, _nval_) \
> > -	IS_ENABLED(CONFIG_OF) && _dev_->of_node ? \
> > -		(OF_DEV_PROP_READ_ARRAY(_dev_->of_node, _propname_, _type_, \
> > -					_val_, _nval_)) : \
> > -		acpi_dev_prop_read(ACPI_COMPANION(_dev_), _propname_, \
> > -				   _proptype_, _val_, _nval_)
> > -
> 
> The macro was used here for a reason.  Can't you replace it with an extended
> macro instead?

OK, I'll change it.

Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/