linux-kernel - Re: [PATCH] video: ocfb: Fix data type warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 12:49:17 +0200
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Qiang Chen <qiang2.chen@...ymobile.com>,
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Qiang Chen <qcwj.lk@...il.com>
Subject: Re: [PATCH] video: ocfb: Fix data type warning

On 05/12/14 10:18, Qiang Chen wrote:
> When allocate framebuffer memory using dma_alloc_coherent(),
> we'd better use dma_addr_t instead of phys_addr_t. Because the
> address we got in fact is DMA or bus address for the platform.
> 
> This patch also fixes below build warning:
> drivers/video/fbdev/ocfb.c:335:2:
> 	warning: passing argument 3 of ‘dma_alloc_attrs’
> 	from incompatible pointer type [enabled by default]
> 
> Signed-off-by: Qiang Chen <qiang2.chen@...ymobile.com>
> ---
>  drivers/video/fbdev/ocfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c
> index 7f9dc9b..de98196 100644
> --- a/drivers/video/fbdev/ocfb.c
> +++ b/drivers/video/fbdev/ocfb.c
> @@ -61,7 +61,7 @@ struct ocfb_dev {
>  	/* flag indicating whether the regs are little endian accessed */
>  	int little_endian;
>  	/* Physical and virtual addresses of framebuffer */
> -	phys_addr_t fb_phys;
> +	dma_addr_t fb_phys;
>  	void __iomem *fb_virt;
>  	u32 pseudo_palette[PALETTE_SIZE];
>  };
> 

Thanks, queued for 3.20.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)