linux-kernel - Re: [PATCH] staging: ft1000: fix else style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1421164899.9233.21.camel@perches.com>
Date:	Tue, 13 Jan 2015 08:01:39 -0800
From:	Joe Perches <joe@...ches.com>
To:	Bilel DRIRA <bilel.dr@...il.com>
Cc:	marek.belisko@...il.com, gregkh@...uxfoundation.org,
	tapaswenipathak@...il.com, gdonald@...il.com, aybuke.147@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix else style error

On Tue, 2015-01-13 at 12:57 +0100, Bilel DRIRA wrote:
> 	ERROR: else should follow close brace '}'
[]
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
[]
> @@ -572,8 +572,7 @@ static void ft1000_hbchk(u_long data)
>  		if (tempword != ho) {
>  			if (info->AsicID == ELECTRABUZZ_ID) {
>  				tempword = ft1000_read_dpram(dev, FT1000_HI_HO);
> -			}
> -			else {
> +			} else {
>  				tempword = ntohs(ft1000_read_dpram_mag_16(dev, FT1000_MAG_HI_HO, FT1000_MAG_HI_HO_INDX));
>  			}
>  		}

True, but you could instead remove all the braces
around both arms from all uses of

	if (test) {
		<single statement>;
	} else {
		<single statement>;
	}

> @@ -688,15 +687,13 @@ static void ft1000_hbchk(u_long data)
>  		if (tempword != hi) {
>  			if (info->AsicID == ELECTRABUZZ_ID) {
>  				ft1000_write_dpram(dev, FT1000_HI_HO, hi);
> -			}
> -			else {
> +			} else {
>  				ft1000_write_dpram_mag_16(dev, FT1000_MAG_HI_HO, hi_mag, FT1000_MAG_HI_HO_INDX);
>  			}

etc...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/