linux-kernel - Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150113162004.GR4160@sirena.org.uk>
Date:	Tue, 13 Jan 2015 16:20:04 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Qais Yousef <qais.yousef@...tec.com>
Cc:	Vinod Koul <vinod.koul@...el.com>, alsa-devel@...a-project.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference

On Tue, Jan 13, 2015 at 03:16:10PM +0000, Qais Yousef wrote:
> On 01/13/2015 02:59 PM, Vinod Koul wrote:

> >>being NULL, hence when trying to set rtd a few lines below we get an oops.
> >It is a good practice to add the oops here

> Will this really be helpful? I think it'll be more clutter (the backtrace on
> metag arch is not great):

It's better in general to leave it out unless it's adding something (for
example sometimes the particular call path is important) and even there
edit it down to relevant details - the splat from the full oops normally
overwhelms the commit message.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)