linux-kernel - Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 17:22:13 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Qais Yousef <qais.yousef@...tec.com>, alsa-devel@...a-project.org,
	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly

At Tue, 13 Jan 2015 20:15:49 +0530,
Vinod Koul wrote:
> 
> On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote:
> > Ping
> > 
> > On 12/19/2014 11:38 AM, Qais Yousef wrote:
> > >Fixes the following compilation error:
> > >
> > >    include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’:
> > >    include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration]
> > >      if (snd_BUG_ON(!stream))
> > >
> > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly,
> > >so include it.
> > >
> > >Signed-off-by: Qais Yousef <qais.yousef@...tec.com>
> > >Cc: Vinod Koul <vinod.koul@...el.com>
> > >Cc: Jaroslav Kysela <perex@...ex.cz>
> > >Cc: Takashi Iwai <tiwai@...e.de>
> > >Cc: linux-kernel@...r.kernel.org
> > >
> Looks okay to me
> 
> Acked-by: Vinod Koul <vinod.koul@...el.com>

Applied now.  Thanks.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/