linux-kernel - Re: [PATCH] staging:vt6655 Add extern variable in head file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150113171239.GA12822@kroah.com>
Date:	Tue, 13 Jan 2015 09:12:39 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	sun wang <sun.wxg@...il.com>
Cc:	Forest@...4free.local, Bond@...4free.local,
	forest@...ttletooquiet.net, Greg@...4free.local,
	Kroah-Hartman@...4free.local, guido@...guardiasur.com.ar,
	Silvio@...4free.local, Fricke@...4free.local,
	silvio.fricke@...il.com, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging:vt6655 Add extern variable in head file

On Tue, Jan 13, 2015 at 04:31:14PM +0800, sun wang wrote:
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes. 
> 
> Signed-off-by: Sun Wang <sun.wxg@...il.com>
> ---
>  drivers/staging/vt6655/ioctl.c | 1 -
>  drivers/staging/vt6655/ioctl.h | 5 +++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
> index 970e80d..716fc89 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -31,7 +31,6 @@
>   */
>  
>  #include "ioctl.h"
> -#include "iocmd.h"
>  #include "mac.h"
>  #include "card.h"
>  #include "hostap.h"
> diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
> index 2dc5a57..42f6910 100644
> --- a/drivers/staging/vt6655/ioctl.h
> +++ b/drivers/staging/vt6655/ioctl.h
> @@ -30,6 +30,11 @@
>  #define __IOCTL_H__
>  
>  #include "device.h"
> +#include "iocmd.h"
> +
> +#ifdef WPA_SM_Transtatus
> +extern SWPAResult wpa_Result;
> +#endif

I don't understand, what problem is this solving?  This variable isn't
in the driver at all.

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/