linux-kernel - Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9dFdvPM-qbhPOZ=4KLs2OB5PYSzaog6byzCvV8N-72uxJ5cQ@mail.gmail.com>
Date:	Tue, 13 Jan 2015 13:19:13 -0400
From:	Marc Dionne <marc.c.dionne@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	jesper.nilsson@...s.com, Al Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-cris-kernel@...s.com
Subject: Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()

On Tue, Jan 13, 2015 at 12:38 PM, David Howells <dhowells@...hat.com> wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
>
> Found with: git grep '[.>]f_dentry'
>
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
>
>  arch/cris/arch-v32/drivers/sync_serial.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
> index 08a313fc2241..e9b6de2b46a0 100644
> --- a/arch/cris/arch-v32/drivers/sync_serial.c
> +++ b/arch/cris/arch-v32/drivers/sync_serial.c
> @@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
>                                   struct timespec *ts)
>  {
>         unsigned long flags;
> -       int dev = MINOR(file->f_dentry->d_inode->i_rdev);
> +       int dev = MINOR(file_inode(file_inode)->i_rdev);

Shouldn't that be file_inode(file) ?

>         int avail;
>         struct sync_port *port;
>         unsigned char *start;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/