linux-kernel - Re: [GIT PULL] platform-drivers-x86 for 3.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 10:04:55 -0800
From:	Andrew Lutomirski <luto@....edu>
To:	Darren Hart <dvhart@...radead.org>
Cc:	"Kirill A. Shutemov" <kirill@...temov.name>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] platform-drivers-x86 for 3.19

On Tue, Jan 13, 2015 at 9:56 AM, Darren Hart <dvhart@...radead.org> wrote:
> On Mon, Jan 12, 2015 at 02:12:44PM -0800, Andrew Lutomirski wrote:
>> On Mon, Jan 12, 2015 at 12:30 PM, Kirill A. Shutemov
>> <kirill@...temov.name> wrote:
>> > On Mon, Jan 12, 2015 at 12:05:45PM -0800, Andrew Lutomirski wrote:
>> >> On Mon, Jan 12, 2015 at 12:03 PM, Kirill A. Shutemov
>> >> <kirill@...temov.name> wrote:
>> >> > On Mon, Jan 12, 2015 at 10:42:11AM -0800, Andrew Lutomirski wrote:
>> >> >> On Mon, Jan 12, 2015 at 10:38 AM, Darren Hart <dvhart@...radead.org> wrote:
>> >> >> > On Mon, Jan 12, 2015 at 12:58:02AM +0200, Kirill A. Shutemov wrote:
>> >> >> >> On Thu, Dec 18, 2014 at 09:51:27AM -0800, Darren Hart wrote:
>> >> >> >> > thinkpad-acpi using software mute simplifies the driver and the user experience
>> >> >> >> > significantly.
>> >> >> >>
>> >> >> >> Except when it doesn't.
>> >> >> >>
>> >> >> >> I'm probably in minority, but I don't use fancy userspace to mess with my
>> >> >> >> mixer and the mute button worked just fine for me before the change.
>> >> >> >> Wasted half an hour to find out what happened is not a pure win from user
>> >> >> >> experience point of view.
>> >> >> >>
>> >> >> >> Is it really necessary to have software_mute_requested == true by default?
>> >> >> >> Can fancy userspace ask for desired behaviour instead and change kernel to
>> >> >> >> not send hotkeys change notification until software_mute is enabled?
>> >> >> >>
>> >> >> >> --
>> >> >> >>  Kirill A. Shutemov
>> >> >> >>
>> >> >> >
>> >> >> > Thanks for the report Kirill,
>> >> >> >
>> >> >> > Andy, we're at RC4, so if we need to fix (or revert) this fix, we only have a
>> >> >> > couple weeks to do so.
>> >> >> >
>> >> >> > Kirill, to define the scope of the problem, if you specify
>> >> >> > software_mute_requested as false on the kernel command line, does your system
>> >> >> > function as expected?
>> >> >>
>> >> >> If I understood Kirill's email correctly, the only issue is that he
>> >> >> liked the old behavior.  Kirill, is that correct?
>> >> >
>> >> > Yes. For now I use thinkpad_acpi.software_mute=0 to get old behaviour.
>> >> >
>> >>
>> >> What aspect of the old behavior is better than the new default behavior?
>> >
>> > It's not necessary better. The new behavior just broke my use-case.
>> >
>> > I don't have anything in my system what would react on KEY_MUTE and I used
>> > the functionality platform provides until it suddenly stopped working.
>> >
>> > I personally can live with new thinkpad_acpi. I'll probably update my
>> > configuration to react on the software button.
>> >
>> > But who else will get frustrated after update to v3.19?
>>
>> Can you try the equivalent of:
>>
>> bindsym XF86AudioMute exec amixer -q set Master toggle
>>
>> for your desktop environment?  Note that this is exactly what you'd do
>> if you were using any laptop that wasn't a thinkpad.
>
> Unless we hear back from Kirill on why this isn't workable, I'm inclined to
> leave this as is. Between the kernel module option and this keybinding,
> equivalent behavior can be easily achieved, and the general use case is
> significantly improved.
>
> The current gap appears to be the mute LED in the button itself, which can be
> addressed moving forward.

I should have clarified this better.  The command:

amixer -q set Master toggle

should toggle the mute LED in sync with the master mixer on all
ThinkPad models with a mute LED.  This works on my X220, and Borislav
confirmed off-list that it works on his X230.  If there's a ThinkPad
with a mute LED on which this doesn't work, then IMO it's a bug and
should be fixed.

--Andy

>
> --
> Darren Hart
> Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/