linux-kernel - Re: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 04:49:42 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...hat.com>
CC:	"namhyung@...nel.org" <namhyung@...nel.org>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"Alexey.Brodkin@...opsys.com" <Alexey.Brodkin@...opsys.com>,
	Borislav Petkov <bp@...e.de>, Cody P Schafer <dev@...yps.com>
Subject: Re: [PATCH v2 1/5] perf tools: [uclibc] fix statfs.f_type data type
 mismatch build error

On Tuesday 13 January 2015 07:18 AM, Arnaldo Carvalho de Melo wrote:

Em Mon, Jan 12, 2015 at 12:05:22PM +0100, Jiri Olsa escreveu:


> On Sat, Jan 10, 2015 at 04:40:50PM +0530, Vineet Gupta wrote:


> > From: Alexey Brodkin <abrodkin@...opsys.com><mailto:abrodkin@...opsys.com>
> >
> > ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers
> > statfs defines f_type to be U32 which causes perf build breakage
> >
> > http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h
> >
> > ----------->8---------------
> >   CC       fs/fs.o
> > fs/fs.c: In function 'fs__valid_mount':
> > fs/fs.c:82:24: error: comparison between signed and unsigned integer
> > expressions [-Werror=sign-compare]
> >   else if (st_fs.f_type != magic)
> >                         ^
> > cc1: all warnings being treated as errors
> > ----------->8---------------
> >
> > Cc: Borislav Petkov <bp@...e.de><mailto:bp@...e.de>
> > Cc: Jiri Olsa <jolsa@...nel.org><mailto:jolsa@...nel.org>
> > Cc: Cody P Schafer <dev@...yps.com><mailto:dev@...yps.com>
> > Cc: Arnaldo Carvalho de Melo <acme@...hat.com><mailto:acme@...hat.com>
> > Cc: linux-perf-users@...r.kernel.org<mailto:linux-perf-users@...r.kernel.org>
> > Cc: linux-kernel@...r.kernel.org<mailto:linux-kernel@...r.kernel.org>
> > Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com><mailto:abrodkin@...opsys.com>


>
> Acked-by: Jiri Olsa <jolsa@...nel.org><mailto:jolsa@...nel.org>


Thanks, applied, but please do not start lines in the changelog comment
with ---, that breaks some patch applying scripts. I fixed it up this
time.

Thx. I've udpated the changelogs so scissor lines start at column 3 with leading whitespace, is that OK or do you want me to remove those lines altogether. Also do u want me to drop this patch from v3 of series as I have some fixups for other patches.

Thx,
-Vineet



- Arnaldo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/