linux-kernel - Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 11:10:43 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Krzysztof Adamski <k@...ko.eu>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private
 members.

On Tue, Jan 13, 2015 at 07:59:18PM +0100, Krzysztof Adamski wrote:
> On Tue, Jan 13, 2015 at 10:52:00AM -0800, Greg Kroah-Hartman wrote:
> >On Tue, Jan 13, 2015 at 07:42:28PM +0100, Krzysztof Adamski wrote:
> >>On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote:
> >>>On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote:
> >>>>This patch fixes checkpatch.pl warning:
> >>>>WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
> >>>>addresses are __aligned(2)
> >>>>
> >>>>current_net_addr and permanent_net_addr members of vnt_private alignment
> >>>>is changed to at last 16 bits so that ether_addr_copy can be safely used
> >>>>on them.
> >>>>
> >>>>buf->data is of type ieee80211_cts which is already properly aligned.
> >>>>
> >>>>Signed-off-by: Krzysztof Adamski <k@...ko.eu>
> >>>>---
> >>>>drivers/staging/vt6656/device.h   |    4 ++--
> >>>>drivers/staging/vt6656/main_usb.c |    3 ++-
> >>>>drivers/staging/vt6656/rxtx.c     |    4 ++--
> >>>>3 files changed, 6 insertions(+), 5 deletions(-)
> >>>
> >>>Doesn't apply to my tree :(
> >>
> >>Strange, I was trying to apply this on your tree to fix any conflicts but
> >>apparently you already has this patch in your staging-testing branch. And as
> >>far as I can tell I only sent it once to you.
> >
> >I think you sent it lots of times, if it's there already, don't worry
> >about it :)
> 
> I've send two other patches for this driver twise but this one only once.
> But that's not imporant. While we're at this, if I ever feel like I should
> resend the patch because it was lost (I promise I will wait much longer:)),
> what would be the best way to mark it as resent? Should it be v2 even though
> it wasn't really changed? Or write it in comment after "---", or maybe some
> other way? That's the only thing not explained in your "Write and Submit
> your first Linux kernel Patch" talk.

Add a "resend" where you would have put "v2" in the subject line.  It's
pretty rare to need to do this, be more patient for me to apply stuff
during the merge window and the holidays please. :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/