linux-kernel - Re: [PATCH 0/5] leverage FAULT_FOLL_ALLOW_RETRY in get_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJu=L58eMD6yfdo3rKZ_QhSVyQkjKQOpTiboDsmcefYj=0rwYQ@mail.gmail.com>
Date:	Tue, 13 Jan 2015 11:26:36 -0800
From:	Andres Lagar-Cavilla <andreslc@...gle.com>
To:	Andrea Arcangeli <aarcange@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Michel Lespinasse <walken@...gle.com>,
	Andrew Jones <drjones@...hat.com>,
	Hugh Dickins <hughd@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Minchan Kim <minchan@...nel.org>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	"\\Dr. David Alan Gilbert\\" <dgilbert@...hat.com>,
	Peter Feiner <pfeiner@...gle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	David Miller <davem@...emloft.net>,
	Steve Capper <steve.capper@...aro.org>,
	Johannes Weiner <jweiner@...hat.com>
Subject: Re: [PATCH 0/5] leverage FAULT_FOLL_ALLOW_RETRY in get_user_pages try#2

On Tue, Jan 13, 2015 at 8:37 AM, Andrea Arcangeli <aarcange@...hat.com> wrote:
> Last submit didn't go into -mm/3.19-rc, no prob but here I retry
> (possibly too early for 3.20-rc but I don't expect breakages in this
> area post -rc4) after a rebase on upstream.

The series looks good to me, I didn't spot any material changes from last time.

I would fold patches 3 & 4 together: it's the same idea behind both,
just different parts of the tree.

You could argue also for folding 1 &2 together, the "damage" is done
in 1, 2 as a standalone results in an (IMHO) unnecessarily large diff.

Thanks,
Andres


------ 8< snipping the rest ---------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/