linux-kernel - Re: randconfig build error with next-20150113, in sound/pci/hda/patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hvbka1mo3.wl-tiwai@suse.de>
Date:	Tue, 13 Jan 2015 20:54:36 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Jim Davis <jim.epost@...il.com>
Cc:	David Henningsson <david.henningsson@...onical.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	perex <perex@...ex.cz>, alsa-devel@...a-project.org
Subject: Re: randconfig build error with next-20150113, in sound/pci/hda/patch_realtek.c

At Tue, 13 Jan 2015 11:39:12 -0700,
Jim Davis wrote:
> 
> Building with the attached random configuration file,
> 
> sound/built-in.o: In function `alc280_fixup_hp_gpio2_mic_hotkey':
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3512: undefined
> reference to `input_allocate_device'
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3520: undefined
> reference to `input_register_device'
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3522: undefined
> reference to `input_free_device'
> /home/jim/linux/sound/pci/hda/patch_realtek.c:3550: undefined
> reference to `input_unregister_device'
> sound/built-in.o: In function `gpio2_mic_hotkey_event':
> /home/jim/linux/include/linux/input.h:392: undefined reference to `input_event'
> /home/jim/linux/include/linux/input.h:417: undefined reference to `input_event'
> /home/jim/linux/include/linux/input.h:392: undefined reference to `input_event'
> /home/jim/linux/include/linux/input.h:417: undefined reference to `input_event'
> make: *** [vmlinux] Error 1

Thanks.  So this is the case where the audio driver is built-in while
the input driver is module.

I guess the cleanest workaround is just to select INPUT from
SND_HDA_CODEC_REALTEK in sound/pci/hda/Kconfig.  Practically seen,
CONFIG_INPUT is always set, so there must be no real drawback with it.
(And we can reduce a few lines as a bonus.)

David, care to prepare a patch?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/