linux-kernel - Re: [Xen-devel] [PATCH v2 2/2] x86/xen: allow privcmd hypercalls to be preempted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150113212140.GD27566@wotan.suse.de>
Date:	Tue, 13 Jan 2015 22:21:40 +0100
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>, mingo@...hat.com,
	peterz@...radead.org, jgross@...e.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org,
	luto@...capital.net, david.vrabel@...rix.com, JBeulich@...e.com,
	hpa@...or.com, masami.hiramatsu.pt@...achi.com,
	xen-devel@...ts.xenproject.org, tglx@...utronix.de,
	Borislav Petkov <bp@...e.de>, bpoirier@...e.de
Subject: Re: [Xen-devel] [PATCH v2 2/2] x86/xen: allow privcmd hypercalls
	to be preempted

On Thu, Dec 18, 2014 at 02:23:14PM -0500, Konrad Rzeszutek Wilk wrote:
> > index 0000000..b5a3e98
> > --- /dev/null
> > +++ b/drivers/xen/preempt.c
> > @@ -0,0 +1,17 @@
> > +/*
> > + * Preemptible hypercalls
> > + *
> > + * Copyright (C) 2014 Citrix Systems R&D ltd.
> > + *
> > + * This source code is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of the
> > + * License, or (at your option) any later version.
> > + */
> > +
> > +#include <xen/xen-ops.h>
> > +
> > +#ifndef CONFIG_PREEMPT
> > +DEFINE_PER_CPU(bool, xen_in_preemptible_hcall);
> > +EXPORT_SYMBOL_GPL(xen_in_preemptible_hcall);
> > +#endif
> 
> Please also add this in the patch:
> 
> 
> diff --git a/drivers/xen/preempt.c b/drivers/xen/preempt.c
> index b5a3e98..5d773dc 100644
> --- a/drivers/xen/preempt.c
> +++ b/drivers/xen/preempt.c
> @@ -13,5 +13,5 @@
>  
>  #ifndef CONFIG_PREEMPT
>  DEFINE_PER_CPU(bool, xen_in_preemptible_hcall);
> -EXPORT_SYMBOL_GPL(xen_in_preemptible_hcall);
> +EXPORT_PER_CPU_SYMBOL_GPL(xen_in_preemptible_hcall);
>  #endif

Ammended, although I think we want another approach now based
on the recommendations by Andy Lutomirski.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/