linux-kernel - Re: [PATCH 3/5] pstore: handle zero-sized prz in series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B5AD71.80404@android.com>
Date:	Tue, 13 Jan 2015 15:42:41 -0800
From:	Mark Salyzyn <salyzyn@...roid.com>
To:	Kees Cook <keescook@...omium.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 3/5] pstore: handle zero-sized prz in series

On 01/13/2015 03:08 PM, Kees Cook wrote:
> On Tue, Jan 13, 2015 at 2:32 PM, Mark Salyzyn <salyzyn@...roid.com> wrote:
>> ramoops_pstore_read fails to return the next in a prz
>> series after first zero-sized entry, not venturing to
>> the next non-zero entry.
>>
>> Signed-off-by: Mark Salyzyn <salyzyn@...roid.com>
> This seems fine. Out of curiosity, when was the bad behavior this encountered?
During integration testing of the pmsg interface, we found that if any 
(most notably ftrace) of the previous prz's were zero in length. Before 
the addition of pmsg it would have occurred if you zero'd the console 
size, but had ftrace set; an unlikely scenario _until_ pmsg was added.
>
> Acked-by: Kees Cook <keescook@...omium.org>
>
> Thanks!
>
> -Kees
>
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/