linux-kernel - Re: [PATCH v3] tty: serial: msm_serial: code cleanup in msm_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B465B0.6080206@codeaurora.org>
Date:	Mon, 12 Jan 2015 16:24:16 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>
CC:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-arm-msm@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tty: serial: msm_serial: code cleanup in msm_console_setup

On 01/12/2015 05:45 AM, Pramod Gurav wrote:
> The change does following:
>  - baud, flow, bits, parity were being overwritten as they were
>    being reinitialized after parsing.  Initialize them when they are
>    declared so that user provided setting are not overwritten.
>  - msm_set_baud_rate() is anyway called in uart_set_options when it calls
>    msm_set_termios(). msm_reset() is called when we change the baud rate.
>    Hence doing away with both of these calls.
>  - CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate.
>    So do away with this here.
>
> Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
>

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/