linux-kernel - Re: [PATCH] staging:vt6655 Add extern variable in head file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150113033640.GB31093@kroah.com>
Date:	Mon, 12 Jan 2015 19:36:40 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	sunwxg <sun.wxg@...il.com>
Cc:	Forest Bond <forest@...ttletooquiet.net>,
	Guido Martínez <guido@...guardiasur.com.ar>,
	Silvio Fricke <silvio.fricke@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:vt6655 Add extern variable in head file

On Tue, Dec 16, 2014 at 03:39:50PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@...il.com>
> 
> Subject: [PATCH] staging:vt6655 Add extern variable in head file

Why is this in the middle of the patch?  I would have to hand edit it
out :(

> 
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes. 

Always wrap your changelog at 72 columns.

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/