linux-kernel - Re: [PATCH] staging: android: fix coding style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1839300.4mCDOMkO8E@wuerfel>
Date:	Wed, 14 Jan 2015 09:32:20 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Patrick Boettcher <patrick.boettcher@...teo.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	Peter Senna Tschudin <peter.senna@...il.com>,
	Daniel Vetter <daniel@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...onical.com>,
	Tapasweni Pathak <tapaswenipathak@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: android: fix coding style error

On Wednesday 14 January 2015 09:20:42 Patrick Boettcher wrote:
> diff --git a/drivers/staging/android/sync_debug.c b/drivers/staging/android/sync_debug.c
> index 1532a86..9a2aaf8 100644
> --- a/drivers/staging/android/sync_debug.c
> +++ b/drivers/staging/android/sync_debug.c
> @@ -96,7 +96,8 @@ static void sync_print_pt(struct seq_file *s, struct sync_pt *pt, bool fence)
>                    sync_status_str(status));
>  
>         if (status <= 0) {
> -               struct timespec64 ts64 = ktime_to_timespec64(pt->base.timestamp);
> +               struct timespec64 ts64 =
> +                   ktime_to_timespec64(pt->base.timestamp);
>  
>                 seq_printf(s, "@%lld.%09ld", (s64)ts64.tv_sec, ts64.tv_nsec);
>         }
> 

You are not really improving readability by just wrapping the line
arbitrarily though.

If you're offended by the long line, better rework the code so the long
line is not needed.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/