linux-kernel - Re: [PATCH] mm: vmscan: fix the page state calculation in too_many

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54B652BF.9020300@codeaurora.org>
Date:	Wed, 14 Jan 2015 16:57:59 +0530
From:	Vinayak Menon <vinmenon@...eaurora.org>
To:	Johannes Weiner <hannes@...xchg.org>
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, vdavydov@...allels.com, mhocko@...e.cz,
	mgorman@...e.de, minchan@...nel.org
Subject: Re: [PATCH] mm: vmscan: fix the page state calculation in too_many_isolated

On 01/13/2015 09:39 PM, Johannes Weiner wrote:
> On Tue, Jan 13, 2015 at 04:37:27PM +0530, Vinayak Menon wrote:
>> @@ -1392,6 +1392,44 @@ int isolate_lru_page(struct page *page)
>>   	return ret;
>>   }
>>
>> +static int __too_many_isolated(struct zone *zone, int file,
>> +	struct scan_control *sc, int safe)
>> +{
>> +	unsigned long inactive, isolated;
>> +
>> +	if (file) {
>> +		if (safe) {
>> +			inactive = zone_page_state_snapshot(zone,
>> +					NR_INACTIVE_FILE);
>> +			isolated = zone_page_state_snapshot(zone,
>> +					NR_ISOLATED_FILE);
>> +		} else {
>> +			inactive = zone_page_state(zone, NR_INACTIVE_FILE);
>> +			isolated = zone_page_state(zone, NR_ISOLATED_FILE);
>> +		}
>> +	} else {
>> +		if (safe) {
>> +			inactive = zone_page_state_snapshot(zone,
>> +					NR_INACTIVE_ANON);
>> +			isolated = zone_page_state_snapshot(zone,
>> +					NR_ISOLATED_ANON);
>> +		} else {
>> +			inactive = zone_page_state(zone, NR_INACTIVE_ANON);
>> +			isolated = zone_page_state(zone, NR_ISOLATED_ANON);
>> +		}
>> +	}
>
> 	if (safe) {
> 		inactive = zone_page_state_snapshot(zone, NR_INACTIVE_ANON + 2*file)
> 		isolated = zone_page_state_snapshot(zone, NR_ISOLATED_ANON + file)
> 	} else {
> 		inactive = zone_page_state(zone, NR_INACTIVE_ANON + 2*file)
> 		isolated = zone_page_state(zone, NR_ISOLATED_ANON + file)
> 	}
>

Ok. Will change that.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/