linux-kernel - Re: [PATCH] arm: mach-versatile: core: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdan1BZQnYgTdF9ctbLOPNoDwDX3Epy8Xfttd2v4-G-4Lw@mail.gmail.com>
Date:	Wed, 14 Jan 2015 12:53:07 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	"arm@...nel.org" <arm@...nel.org>, Bryan Wu <cooloney@...il.com>
Cc:	Russell King <linux@....linux.org.uk>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm: mach-versatile: core: Remove unused function

On Sat, Jan 3, 2015 at 5:52 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:

> Remove the function versatile_leds_event() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

That's right, the code was made redundant in
commit e031cd513ec2ff661465dc1198220075719e72d1
"ARM: mach-realview and mach-versatile: retire custom LED code"

ARM SoC folks: I suggest you apply this patch directly to your cleanup
branch.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/