linux-kernel - Re: [PATCH v1] gpio: Make the vararg hacks not pass magic values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYg=bwRtsj8gbxbZnLtg+746xoJQcQf9FdNkhh_poR=PA@mail.gmail.com>
Date:	Wed, 14 Jan 2015 13:33:36 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Olliver Schinagl <oliver+list@...inagl.nl>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	Olliver Schinagl <oliver@...inagl.nl>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] gpio: Make the vararg hacks not pass magic values

On Wed, Jan 7, 2015 at 9:44 AM, Olliver Schinagl
<oliver+list@...inagl.nl> wrote:

> From: Olliver Schinagl <oliver@...inagl.nl>
>
> Right now, in consumer.h, there's some vararg hacks that pass 0 as the
> flags. What actually is passed however is GPIOD_ASIS, which naturally is
> also 0. Using the define/enum rather then the magic 0 makes it the
> define more readable to a passer by.
>
> Signed-off-by: Olliver Schinagl <oliver@...inagl.nl>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/