linux-kernel - Re: [PATCH] Added PIDs for Actisense USB Devices Signed-off-by: Mark Glover <mark@...isense.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150114125220.32654.qmail@stuge.se>
Date:	Wed, 14 Jan 2015 13:52:19 +0100
From:	Peter Stuge <peter@...ge.se>
To:	Mark Glover <mark@...isense.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Added PIDs for Actisense USB Devices Signed-off-by:
	Mark Glover <mark@...isense.com>

Please update your commit message to leave one blank line between the
commit message summary and the rest of the message. (This avoids your
signed-off-by ending up in the email subject.)

Mark Glover wrote:
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
..
> +#define CHETCO_SEAGAUGE_PID		0xA548 /* SeaGauge USB Adapter */
> +#define CHETCO_SEAGAUGE__PID		0xA549 /* SeaSwitch USG Apadter */

Please make the macro name match the product name. Also note typo^ here.


//Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/