[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54B671DA.7020009@atmel.com>
Date: Wed, 14 Jan 2015 14:40:42 +0100
From: Nicolas Ferre <nicolas.ferre@...el.com>
To: Boris Brezillon <boris.brezillon@...e-electrons.com>
CC: Thomas Gleixner <tglx@...utronix.de>,
Jason Cooper <jason@...edaemon.net>,
Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 4/5] ARM: at91/dt: add AIC irq1 muxed peripheral id
definitions
Le 14/01/2015 14:34, Boris Brezillon a écrit :
> On Wed, 14 Jan 2015 14:21:47 +0100
> Nicolas Ferre <nicolas.ferre@...el.com> wrote:
>
>> Le 13/01/2015 19:46, Boris Brezillon a écrit :
>>> These ids will be used to define irqs multiplexed on the first irq line.
>>>
>>> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
>>> ---
>>> .../dt-bindings/interrupt-controller/atmel-aic.h | 22 ++++++++++++++++++++++
>>> 1 file changed, 22 insertions(+)
>>> create mode 100644 include/dt-bindings/interrupt-controller/atmel-aic.h
>>>
>>> diff --git a/include/dt-bindings/interrupt-controller/atmel-aic.h b/include/dt-bindings/interrupt-controller/atmel-aic.h
>>> new file mode 100644
>>> index 0000000..e14a94f
>>> --- /dev/null
>>> +++ b/include/dt-bindings/interrupt-controller/atmel-aic.h
>>> @@ -0,0 +1,22 @@
>>> +#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_ARM_GIC_H
>>> +#define _DT_BINDINGS_INTERRUPT_CONTROLLER_ARM_GIC_H
>>
>> Nit.: why ARM_GIC?
>
> Because I copied it from the arm-gic.h header and forgot to rename
> those macros :-).
> I'll fix that.
>
>>
>>> +#include <dt-bindings/interrupt-controller/irq.h>
>>> +
>>> +#define AIC_IRQ1_PMC 0
>>> +#define AIC_IRQ1_ST 1
>>> +#define AIC_IRQ1_PIT 1
>>> +#define AIC_IRQ1_DBGU 2
>>> +#define AIC_IRQ1_RTC 3
>>> +#define AIC_IRQ1_RTT 4
>>> +#define AIC_IRQ1_WATCHDOG 5
>>> +#define AIC_IRQ1_MC 6
>>> +#define AIC_IRQ1_SDRAMC 6
>>> +#define AIC_IRQ1_DDRSDRC 6
>>> +#define AIC_IRQ1_RSTC 7
>>> +#define AIC_IRQ1_PMERRLOC 8
>>> +#define AIC_IRQ1_PMECC 9
>
> Following up the discussion we had privately regarding these
> macros (whether we really need them or not), maybe adding a comment
> above the irqs property would be enough:
>
> dumb_irq1_demux: dumb-irq-demux@1 {
> compatible = "irqchip-dumb-demux";
> interrupt-controller;
> #interrupt-cells = <1>;
> interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> /*
> * Interrupt lines:
> * 0: PMC
> * 1: PIT
> * 2: DBGU
> * 3: RTT
> * 4: WATCHDOG
> * 5: RSTC
> */
> irqs = <0x3f>;
> };
Well, I tend to prefer when no additional macros are defined in DT for
no real added value. So, this comment seems to be enough... I would vote
for this solution ;-)
Thanks, bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists