linux-kernel - Re: Bug with jprobes and function graph tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150114084930.06e9daf1@gandalf.local.home>
Date:	Wed, 14 Jan 2015 08:49:30 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, vvs@...ru
Subject: Re: Bug with jprobes and function graph tracer

On Tue, 13 Jan 2015 21:46:33 +0900
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:

> > 
> > I worked on this for the last few days and have a patch that fixes the
> > problem. I'll be posting it later today. It also uncovered another
> > unrelated bug that I worked on yesterday, otherwise I would have posted
> > these fixes already.
> 
> Great! I look forward that! :)

I was all set to send the patches but during testing found that this
isn't just affected by the fentry code, but also happens when jprobes
and kprobes uses the breakpoint method (old mcount and i386).

I guess this has always been broken from when jprobes and function
graph tracing were together.

Anyway, I think I have a simpler solution which simulates making the
jprobes "notrace". At least this solution will allow us to have jprobe
callbacks traced in the future. But for now, instead of crashing, we'll
just disable function graph tracing while its in a jprobe.

I'll see if I can get that patch working today (I should stop saying
that).

But all is not lost. I found two bugs in the current implementation of
the function graph tracer because of this :-)

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/