linux-kernel - [PATCH 0/3] Use of_get_child_by_name() instead of of_find_node_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1421243519-6257-1-git-send-email-geert+renesas@glider.be>
Date:	Wed, 14 Jan 2015 14:51:56 +0100
From:	Geert Uytterhoeven <geert+renesas@...der.be>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Bryan Wu <cooloney@...il.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Jingoo Han <jg1.han@...sung.com>,
	Lee Jones <lee.jones@...aro.org>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: [PATCH 0/3] Use of_get_child_by_name() instead of of_find_node_by_name()

	Hi Ben, Bryan/Richard, Jingoo/Lee,

Internally, of_find_node_by_name() calls of_node_put() on its "from"
parameter.  This is a problem if that device_node will be used
afterwards, or if of_node_put() is called on it again (either manually
or in a for_each_*_node() loop) later, as that may cause a zero kref
refcount. This may be caught by the system if CONFIG_OF_DYNAMIC=y:

	ERROR: Bad of_node_put() on /....

Use of_get_child_by_name() instead to fix this, and remove existing
workarounds to pre-increase the refcount.

Compile-tested only.

Geert Uytterhoeven (3):
  powerpc/pmac: Fix DT refcount imbalance in pmac_pic_probe_oldstyle
  leds: leds-mc13783: Use of_get_child_by_name() instead of refcount
    hack
  backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount
    hack

 arch/powerpc/platforms/powermac/pic.c | 2 +-
 drivers/leds/leds-mc13783.c           | 4 +---
 drivers/video/backlight/88pm860x_bl.c | 5 +----
 3 files changed, 3 insertions(+), 8 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/