linux-kernel - Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9352624.oIKUSW0aDp@xps13>
Date:	Wed, 14 Jan 2015 15:07:21 +0100
From:	Gabriele Mazzotta <gabriele.mzt@...il.com>
To:	dvhart@...radead.org
Cc:	mjg59@...f.ucam.org, pali.rohar@...il.com,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	A.Sloman@...bham.ac.uk, computersforpeace@...il.com
Subject: Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS

Hi,

I decided to remove "als" from input_triggers and created a dedicated
sysfs file for it. Having it there was wrong and misleading.
I also updated the documentation to reflect this change and fixed the
wrong description of als_setting, now used for als_enabled.

Is returning -ENODEV only when writing to als_enabled the right thing
to do or should it be returned also when reading als_enabled?

Thanks,
Gabriele
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/